Hello there, i had a disscussion with my friend about code align in controllers. Consider these examples:

A) separate functions

function add_user() {
  // code goes gere
}

function edit_user(){
}

function del_user(){
}

B) topic-related function

function user($action){
switch($action) {
 
  case ‘add’:
  // code goes here
  break;
  case ‘edit’:
  break;
 
case ‘del’:
  break;
}
}

Which one is the better way how to organize code in controllers and why is that so?
Thx for answers

I always use the first version, it’s probably because when I used procedural code I had different files for each action, and it just stuck. I can see the benefits of having all the edit functions in one controller, for example.

Although it would get messy if you had a modular structure like I use now, which is why I stick with the first. But then again I would have the whole function in a model and just run it from the controller.

With CI I use the first one, but before I always used switches.

The first way makes you write code that is spread out more which makes it easier to eyes.
The second way you can look for code that is similar in the different actions and you can make it DRY.

I use the second way and put the code in the cases up to ten lines per case, if it’s more i use methods so it’s a third way

I use the first. Always. Personally, I think it’s a better coding practice. I also think the first way is a tad faster. Not sure though.

I would use A as well. It seems to me to be easier to maintain specific functions than have larger switched functions.  Besides, the whole point of object oriented programming is to group functions and variables into data types.  Effectively giving you the badass version of method B.

Method A.  No one has mentioned this, but using style A allows for very exact naming in both your functions and your urls if that matters.

Using style A as it is above, you can have nice clean urls like:

http://mydomain.com/users
http://mydomain.com/users/add
http://mydomain.com/users/edit
http://mydomain.com/users/delete

You get the idea. Using your imagination a little, CI becomes one heck of a search engine optimization tool since it allows you to craft how your urls will appear.

Joe you have to use routing with method A you have nice urls with method B

I did something similar today. I had a controller method for adding/editing records, using the same html form.

Bu I wanted urls like admin/edit and admin/new, so I did:

Keeps the code in one place but looks nice too!

Mei

sorry, see below

xwero - 17 October 2008 04:43 PM

Joe you have to use routing with method A you have nice urls with method B

Aren’t we always?  Doesn’t the routing begin with the index.php examining our uri segments?

With B you don’t have to route to use the user/add segments, for A you have to use the route

I’m using the code from the starter topic.

Thanks guys

just a note: I use add and edit often in the same function call (often it is also the same view with the same form). If an id has been transfered, I would need to mutate a DB-record, otherwise I do an insert.

Hello,

from my point of view, if you think about CI and MVC style, the controller class is the “topic” (who), the controller method is the “action” (what), and the other segments are the arguments.
That’s why I’ll go for option A.

@dready This works perfectly for relatively small controllers (<100 functions) but for larger controllers I find method B to be preffered. Of course, this is just how I like to work.

One can also split controllers but then the theory/practice of topic-method-arguments is busted.

So for small controllers I go for method A, Large controllers I go for method B, extremely large controllers I go for method C