I’d like to see a simple code correction in the following method. You can see that the class has a default $config parameter initialized to FALSE, but the method itself assumes $config is an Array if it is !== NULL. That can introduce some bugs in libraries when $config is passed in as FALSE and not an array.

$config should default to NULL or an empty array.

Using boolean false with == is the correct way to do it, because:

Shadowhand - 26 March 2007 10:30 AM

Using boolean false with == is the correct way to do it, because:

$arr = array();
if ($arr == false) {// Evaluates true
  die ('$arr is empty');
}

if ($arr == null) {// Also evaluates true
  die ('$arr is empty');
}

I don’t think so… you might want to pass an empty array as a config and it will be overwritten by config file, but you are assigning the config values.

Ah, I see what you are saying Seppo. I misinterpreted what you were reporting here. I’ll have to think about this one some more.

Shadowhand - 26 March 2007 10:30 AM

Using boolean false with == is the correct way to do it, because:

The issue at hand here is that $config passed into libraries should be an array, since that’s the design of CI’s configuration files. Each library shouldn’t have to check whether or not that the value passed in is a valid array or not. The Loader should handle that for each library, either passing in an array or nothing, at which point the library’s default parameter value gets passed.

That’s my take anyway.