trim_slashes()

Geert De Deckere

Posted: 14 February 2007 12:45 PM

[ Ignore ]

Lab Assistant

Total Posts: 248

Joined 02-10-2007

Found in string_helper.php at about line 45:

function trim_slashes($str)
{
    return preg_replace("|^/*(.+?)/*$|", "\\1", $str);
} 

What about ...

function trim_slashes($str)
{
    return trim($str, '/');
} 

Or am I just nitpicking again?

Signature

Kohana rocks!

Profile

joeles

Posted: 14 February 2007 07:00 PM

[ Ignore ] [ # 1 ]

Research Assistant

Total Posts: 486

Joined 09-14-2006

I agree and it’s not nitpicking. There are many places throughout CI that use regex when it’s not necessary. Hopefully we can start to weed them out one day.

Signature

Code Igniter 1.5.4 / CentOS 5 / PHP 5.2.3 / Apache 2.2.2 / MySQL 5.0.27

Profile

roosterboy

Posted: 15 February 2007 12:03 AM

[ Ignore ] [ # 2 ]

Summer Student

Total Posts: 19

Joined 12-07-2006

Oops, nevermind. I misread your suggested code.

Profile

‹‹ More database users Suggestion: move app/views dir ››

Username		Remember Me?
Password		forgot password?

Post Marker Legend
	New posts	Hot Topic with new posts	New Poll	Moved Topic	Sticky topic
	No new posts	Hot Topic with no new posts	Old Poll	Closed Topic	Announcements

Visitor Statistics
The most visitors ever was 719, on June 06, 2008 10:16 AM
Total Registered Members:	66414	Total Logged-in Users:	31
Total Topics:	84753	Total Anonymous Users:	0
Total Replies:	454835	Total Guests:	243
Total Posts:	539588