I’ve extended the Input class with a get() method, because there’s no good reason to kill query strings, just because they can be abused.  Remember that “Code Igniter is right for you if... [you] want a framework that does not require you to adhere to restrictive coding rules.”

I don’t know how many people are actually using query strings with CI, because it doesn’t work well, but I’ve got them covered as well with a router change that allows segment data, and the use of the URL helper because you can use URIs like: ‘/index.php?/controller/method/segment?query=foo’

There’s also a bug (when the magic quotes misfeature is enabled) in the CI_Input methods that run stripslashes on the keys of superglobals when they are retrieved, but not the values... a big problem when the database class once-again escapes strings in SQL statements.

To start using this fix/extension, download this ZIP file.  This compressed application folder contains the required MY_Input and MY_Router libraries, an example set of additions to config.php, as well as a basic controller (Ir—Input/Routing) and view for testing.

UPDATE: The input class also now has _list, functions for each method, e.g. get_list().  It accepts a variable length argument list, and there are three ways to use it:

Usage 1: get_list(array(‘username’, ‘password’, ‘passconf’)[, true])
arg1 (array): Required.  List of keys to retrieve values from.
arg2 (bool): Optional, default FALSE. Toggle cross-site scripting filter

Usage 2: get_list(‘username,password,passconf’[, true])
arg1 (string): Required. A comma-delimited list of keys to retrieve values from.
arg2 (bool): Optional, default FALSE.  Toggle cross-site scripting filter

Usage 3: get_list(‘username’, ‘password’, ‘passconf’[, true])
arg1… Keys to retrieve values from
lastarg: Optional, default FALSE.  Toggle cross-site scripting filter

UPDATE: Query string routing is an OPTION.  It was a simple change that came along for the ride in fixing the input class.  One further update I may end up making is to eliminate the query string routing config option and just detect the setting based on the last character of index page.

UPDATE #34480227: The current version does not try to reproduce the original code, unlike the original proof-of-concept.  It also solves the bug that causes CI to not report rsegment #2 when the index method is used.

I personally don’t have any use for your work at this time, but I briefly looked over the code and can recommend one improvement which I think anyone using your work would enjoy.

I haven’t tested this code, but basically it would allow the user to fetch multiple $_GET values at once, instead of individually. If I have five values I want from the query string, I don’t want to make five seperate calls. Hope this helps.

(This is where I posted about a variable argument list version, but now I have something better in the works)

Hate to say it, but I’ve one-upped you by supporting arrays, a string of comma-delimited values, OR a variable-length array of strings.  It does add a few lines of code… not many… but I’ve made them separate functions, e.g. get_list().

Same link:
http://champs.name/ci/input/libraries.zip

Well I don’t care that you ‘one-upped’ me, I just gave you a simple example off the top of my head Good work.

@champs: I have got errors using your classes. The patch from nvidiafx works for me.
http://www.codeigniter.com/forums/viewthread/2659

——
@champs: Sorry, I have deleted my temp project with your classes. There were errors about wrong segments.
——

Why i prefer the nvidiafx’s Input and Router classes?
Because his solution works without

It is compatible with “standard” CI URLs

No question mark needed.

Jozef, that’s not a requirement, it’s just a feature I’ve added for people who can’t or don’t want to set up rewriting rules - maybe because of the server configuration, or the software itself (IIS, etc.)  I’ve updated the original post to make that clear.

Might I add that this is also a solution to the garbage-in, garbage-out problem of CI screwing up input data with magic quotes enabled.

Champs, i have tested it again, but it does not work.
I have installed your classes in application/libraries and changed config.php:

This URL pattern

returns error:

If you’re using query string routing, the pattern should be:
/index.php?/controller?query=foo

Otherwise, if you don’t want to use query string routing, don’t set that config option.  I’ll update the post again.

I have changed to:
$config[‘query_string_routing’] = false;
or removed it from config.php and
still the error for URL /index.php/controller?query=foo

When I get some time in my workday, I’ll check it out.

The problem (from what I can see) is that the inherited CI code has a special short circuit when there’s only one query string parameter.  I thought I squashed that bug, but I guess not.  Will have a fix soon.

... and I’ve posted a fix.

champs - 28 January 2007 04:09 AM

... and I’ve posted a fix.

I have tested it again. It works in my project now
I would like to see support for $_GET in the next CI release !!!

Hey Champs.  This is pretty dense   Could you give the the “executive summary” of what you think should be changed?

Executive summary: consistency.

Whether you use mod_rewrite or not, the router allows an unlimited number of segments, rather than the very lame controller & method triggers, which don’t work with URL helper functions (my mod works withthem).

Data retrieved from the Input class is predictable.  Whether magic quotes are enabled or not, the data received from the Input class will be the same.  If your data is sane coming in, you don’t have to worry about it again until it’s going out.